Re: [PATCH] git-svn: fix auth parameter handling on SVN 1.9.0+

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16 January 2016 at 11:17, Eric Wong <normalperson@xxxxxxxx> wrote:
> For users with "store-passwords = no" set in the "[auth]" section of
> their ~/.subversion/config, SVN 1.9.0+ would fail with the
> following message when attempting to call svn_auth_set_parameter:
>
>   Value is not a string (or undef) at Git/SVN/Ra.pm
>
> Ironically, this breakage was caused by r1553823 in subversion:
>
>   "Make svn_auth_set_parameter() usable from Perl bindings."
>
> Since 2007 (602015e0e6ec), git-svn has used a workaround to make
> svn_auth_set_parameter usable internally.  However this workaround
> breaks under SVN 1.9+, which deals properly with the type mapping
> and fails to recognize our workaround.
>
> For pre-1.9.0 SVN, we continue to use the existing workaround for
> the lack of proper type mapping in the bindings.
>
> Tested under subversion 1.6.17 and 1.9.3.
>
> I've also verified r1553823 was not backported to SVN 1.8.x:
>
>   BRANCH=http://svn.apache.org/repos/asf/subversion/branches/1.8.x
>   svn log -v $BRANCH/subversion/bindings/swig/core.i
>
> ref: https://bugs.debian.org/797705
> Cc: 797705@xxxxxxxxxxxxxxx
> Signed-off-by: Eric Wong <normalperson@xxxxxxxx>
> ---
>  Thanks to the reporter (Bcc:-ed to protect their privacy) who
>  notified Dair and I of this bug.
>
>  Junio: this should also head to maint, thanks.

Thanks, I confirm it fixed the issue.
You can add the following if you want:

Reported-by: Thierry Vignaud <thierry.vignaud@xxxxxxxxx>
Tested-by: Thierry Vignaud <thierry.vignaud@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]