David Turner <dturner@xxxxxxxxxxxxxxxx> writes:
>> > +static int submodule_backend(const char *key, const char *value,
>> > void *data)
>> > +{
>> > + char **path = data;
>> > + if (!strcmp(key, "extensions.refstorage"))
>> > + *path = xstrdup(value);
>> > +}
>>
>> This should return "int" (namely 0).
>
> Fixed, thanks.
By the way, I initially thought "this function should return void",
until I realized that this is a callback function that is required
to have a fixed function signature. It would save future readers a
similar confusion if it is named with "config" somewhere and/or
"_cb" at the end.
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html