Hi Ramsay, On Wed, 13 Jan 2016, Ramsay Jones wrote: > Also, when compiling on Cygwin with NO_LIBGEN_H, I need to > include the following here: > > #undef basename > > in order to suppress approx 230 warnings about the redefinition > of the basename macro. > > (I suppose that should go in the previous commit. dunno) I think this is an incorrect use of NO_LIBGEN_H (because Cygwin obviously has it), but in any case, it is a completely independent issue from fixing/testing basename()/dirname(), so your #undef basename should be in a completely separate commit, methinks. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html