Hi Ramsay, On Wed, 13 Jan 2016, Ramsay Jones wrote: > On 12/01/16 07:57, Johannes Schindelin wrote: > > This mini series adds a fall-back for the `dirname()` function that we use > > e.g. in git-am. This is necessary because not all platforms have a working > > libgen.h. > > > > While at it, we ensure that our basename() drop-in conforms to the POSIX > > specifications. > > I was somewhat disappointed that you ignored the implementation of > gitbasename() and gitdirname() that was included in the test-libgen.c > file that I sent you. I am sorry you feel that I ignored your work! My line of reasoning, however, was to go with the existing gitbasename() and with the gitdirname() I had come up with, because I was already familiar with them. Your tests included a couple of corner cases that neither handled correctly, and I was able to fix that, so I was happy. To be quite honest, I blindly deleted everything but the tests, noticed that the remaining code looked eerily similar to test-path-utils, and merged it there. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html