Re: [PATCH 1/3] Teach 'git pull' to handle --rebase=interactive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Johannes Schindelin <johannes.schindelin@xxxxxx> writes:

> Subject: Re: [PATCH 1/3] Teach 'git pull' to handle --rebase=interactive

Subject: pull: allow interactive rebase with --rebase=interactive

or something?  The same comment applies for the other patches in
this series, and other recent patches from you in general.

> The way builtin pull works, this incidentally also supports the value
> 'interactive' for the 'branch.<name>.rebase' config variable.

That, especially the "incidentally" part, makes it sound as if it is
"because we can easily", not "because it is useful in such and such
way, we must support it".  We definitely want to see patches that
fall into the latter category, and from the sound of 0/3, I think
this one should be advertised as such.

The patch text looks good (admittedly from only a cursory read,
though).

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]