On 11 Jan 2016, at 17:26, Stefan Beller <sbeller@xxxxxxxxxx> wrote: > On Sun, Dec 20, 2015 at 3:19 PM, <larsxschneider@xxxxxxxxx> wrote: > >> +test_expect_success 'submodule update clone shallow submodule on non-default branch' ' >> + git clone cloned super4 && >> + pwd=$(pwd) && >> + (cd super4 && >> + sed -e "s#url = ../#url = file://$pwd/#" <.gitmodules >.gitmodules.tmp && >> + mv -f .gitmodules.tmp .gitmodules && >> + test_must_fail git submodule update --init --depth=3 2>submodule.out && > > Why do we choose a depth of 3 here? I just copied this code from the test above. Let's change that to "--depth=1" to avoid confusion. Should I reroll or can this be fixed in the merge? > >> + test_i18ngrep --count "Commit is probably not on the default branch." submodule.out I was just reading this and wonder if we should remove "--count". My initial intention was to make sure this error message only happens once. However, this is not checked here anyways. >> + ) >> ' >> >> test_expect_success 'submodule update --recursive drops module name before recursing' ' Thanks, Lars -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html