Re: [PATCH v2 2/2] object name: introduce '^{/!-<negativepattern>}' notation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Duy Nguyen <pclouds@xxxxxxxxx> writes:

> On Fri, Jan 8, 2016 at 1:04 PM, Stephen Smith <ischis2@xxxxxxx> wrote:
>>> > +test_expect_success 'ref^{/!-}' '
>>> > +   test_must_fail git rev-parse master^{/!-}
>>> > +'
>
> Shouldn't it be ^{!/... instead of ^{/!... ? People could have a
> pattern starting with "!" and /! will change its meaning. On the other
> hand, anything else after { is still reserved and can safely be used.

http://thread.gmane.org/gmane.comp.version-control.git/40460/focus=40477
clarifies the above, I think.


Back then we seem to have been thinking only about ":" as the
overall "search the history to name an object traversing from all
tips" prefix, but the current one is described in terms of the more
generally useful "<committish>^{/<pattern>}" syntax and the escape
hatch applies--they are both handled by get_sha1_oneline() the same
way.


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]