On Fri, Jan 8, 2016 at 11:21 AM, Johannes Schindelin
<johannes.schindelin@xxxxxx> wrote:
> Junio Hamano pointed out that there is an implicit assumption in pretty
> much all the code calling has_dos_drive_prefix(): it assumes that the
> DOS drive prefix is always two bytes long.
>
> While this assumption is pretty safe, we can still make the code more
> readable and less error-prone by introducing a function that skips the
> DOS drive prefix safely.
>
> While at it, we change the has_dos_drive_prefix() return value: it now
> returns the number of bytes to be skipped if there is a DOS drive prefix.
With this change, code such as:
for (i = has_dos_drive_prefix(src); i > 0; i--)
...
in path.c reads a bit oddly. Renaming the function might help. For instance:
for (i = dos_drive_prefix_len(src); i > 0; i--)
...
> Signed-off-by: Johannes Schindelin <johannes.schindelin@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html