Re: [PATCH v2] git-p4.py: add support for filetype change

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Romain Picard <romain.picard@xxxxxxxxxxx> writes:

> diff --git a/t/t9827-git-p4-change-filetype.sh b/t/t9827-git-p4-change-filetype.sh
> new file mode 100755
> index 0000000..b0a9f62
> --- /dev/null
> +++ b/t/t9827-git-p4-change-filetype.sh
> @@ -0,0 +1,69 @@
> +#!/bin/sh
> +#
> +# Copyright (c) 2016 Romain Picard
> +#
> +
> +test_description='git p4 support for file type change'
> +
> +. ./lib-git-p4.sh
> +
> +test_expect_success 'start p4d' '
> +	start_p4d
> +'
> +
> +test_expect_success 'create files' '
> +	(
> +		cd "$cli" &&
> +		p4 client -o | sed "/LineEnd/s/:.*/:unix/" | p4 client -i &&
> +		cat >file1 <<-EOF &&
> +		This is a first file.
> +		EOF
> +		cat >file2 <<-EOF &&
> +		This is a second file whose type will change.
> +		EOF

Micronit.  It would be nicer to the readers to make it clear that
there is no funny substitution to be worried about by quoting the
end marker of these here document, i.e.

		cat >dest <<-\EOF &&
                text without any funny substitution business
                EOF

> +		p4 add file1 file2 &&
> +		p4 submit -d "add files"
> +	)
> +'
> +
> +test_expect_success 'change file to symbolic link' '

This needs a SYMLINKS prerequisite so that it is skipped on systems
that lack support for symbolic links, i.e.

	test_expect_success SYMLINKS 'change file to symbolic link' '

The same for the next one.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]