Hi Junio,
On Wed, 16 Dec 2015, Junio C Hamano wrote:
> diff --git a/builtin/update-index.c b/builtin/update-index.c
> index a7a9a7e..3a6c5b2 100644
> --- a/builtin/update-index.c
> +++ b/builtin/update-index.c
> @@ -1075,7 +1075,10 @@ int cmd_update_index(int argc, const char **argv, const char *prefix)
> struct strbuf buf = STRBUF_INIT, nbuf = STRBUF_INIT;
>
> setup_work_tree();
> - while (strbuf_getline(&buf, stdin, line_termination) != EOF) {
> +
> + while ((line_termination
> + ? strbuf_getline_crlf(&buf, stdin)
> + : strbuf_getline(&buf, stdin, '\0')) != EOF) {
> char *p;
> if (line_termination && buf.buf[0] == '"') {
Again, I think it would make things clearer and more future proof if we
changed the logic to talk about nul_delimited instead of line_termination.
Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html