On Tue, Dec 29, 2015 at 1:35 PM, Jeff King <peff@xxxxxxxx> wrote: > We sometimes use 32-bit unsigned integers as bit-fields. > It's fine to access the MSB, because it's unsigned. However, > doing so as "1 << 31" is wrong, because the constant "1" is > a signed int, and we shift into the sign bit, causing > undefined behavior. > > We can fix this by using "1U" as the constant. We have this in cache.h, should it be fixed as well? /* CE_EXTENDED2 is for future extension */ #define CE_EXTENDED2 (1 << 31) -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html