Re: [PATCH v4] git-svn: add support for prefixed globs in config

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Victor Leschuk <vleschuk@xxxxxxxxx> writes:

> Introduce prefixed globs for branches and tags in git-svn.
> Globs like 'release_*' allow users to avoid long lines in config like:
>
> branches = branches/{release_20,release_21,release_22,...}
>
> Signed-off-by: Victor Leschuk <vleschuk@xxxxxxxxxxxxxxxx>
> ---
> Changes from v3:
> 	* Wrapped all test preparations in separate test-cases
>
>  Documentation/git-svn.txt        |   5 ++
>  perl/Git/SVN/GlobSpec.pm         |   9 ++-
>  t/t9168-git-svn-prefixed-glob.sh | 142 +++++++++++++++++++++++++++++++++++++++
>  3 files changed, 151 insertions(+), 5 deletions(-)
>  create mode 100755 t/t9168-git-svn-prefixed-glob.sh
>
> diff --git a/Documentation/git-svn.txt b/Documentation/git-svn.txt
> index 0c0f60b..529cffe 100644
> --- a/Documentation/git-svn.txt
> +++ b/Documentation/git-svn.txt
> @@ -1034,6 +1034,7 @@ listed below are allowed:
>  	url = http://server.org/svn
>  	fetch = trunk/project-a:refs/remotes/project-a/trunk
>  	branches = branches/*/project-a:refs/remotes/project-a/branches/*
> +	branches = branches/release_*:refs/remotes/project-a/branches/release_*

Hmph, if you are going this route, I wonder if there is a reason to
limit yourself only to "prefix".  Would allowing something like this:

	branches = branches/pre*post:refs/remotes/project-a/branches/*

i.e., loosening the rule to allow at most one asterisk anywhere on
the left hand side of the colon, and require the same number of
asterisks as the left hand side has on the right hand side of the
colon, be too lax and hurt the users?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]