On Wed, Dec 30, 2015 at 1:27 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > It is more important to envision what we would do in the future when > a command that takes a pattern (or a set of patterns) to match the > refnames with _and_ another pattern (or a set of patterns) to match > something else, and take that into account when designing this > "allowing matching logic for refnames to be customized from glob to > something else" feature, so that we do not paint outselves into a > corner we cannot later get out of. Imagine a hypothetical command > 'git mgrep' that can look for a pattern in tips of multiple branches > that can be used this way: > > $ git mgrep -e 'froo*tz' --refs 'refs/heads/release/*' > > which may look for strings that match "froo*tz" in the trees of > all branches whose name match the pattern 'release/*'. In this > example, the pattern to match strings is a BRE (same default as > "git grep"), and the pattern to match refnames is a glob. > > Consistency & similarity with "git grep" would most likely lead us > to add -E/-F/-G/-P options to this command and to make it affect how > the pattern to match strings works. For example: > > $ git mgrep -E -e 'fro+tz' --match-refs 'refs/heads/release/*' > > may look for the same strings that would match the first example, > but the pattern is expressed in ERE. "-P", "-G", and "-F" options > would also work the same way. > > Now, the question is what this "-E" (or -P/-G/-F) should do with the > matching the command does with the refnames. The easiest (and > laziest) way out from the implementors' point of view might be to > declare that they affect both at the same time. > ... What about not using command line options? We could go with something like pathspec magic. I think as long as we provide three options: literal, some pattern matching and backquote, then the user has enough flexibility to specify any set of refs. For pattern matching I'd prefer wildmatch. regex can be used via backquote, e.g. `for-each-ref | grep ...` (or teach for-each-ref about regex to avoid grep). -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html