On 12/29/2015 06:55 AM, Jeff King wrote: > On Sun, Dec 20, 2015 at 02:26:37AM -0500, Jeff King wrote: > >> I noticed that an interrupt "git symbolic-ref" will not clean up >> "HEAD.lock". So I started this series as an attempt to convert >> create_symref() to "struct lock_file" to get the usual tempfile cleanup. > > Here's version 2, based on comments from Michael. The first two patches > were picked out separately for jk/symbolic-ref-maint, so I've dropped > them here (so 1+2 here are the original 3+4). > > The other differences from v1 are: > > - use "refname" instead of "ref" to match surrounding code > > - drop adjust_shared_perm, as lockfile does it for us > > - adjust reflog writing order (done in a new patch) > > The patches are: > > [1/3]: create_symref: modernize variable names > [2/3]: create_symref: use existing ref-lock code > [3/3]: create_symref: write reflog while holding lock Thanks, Peff. The whole series is Reviewed-by: Michael Haggerty <mhagger@xxxxxxxxxxxx> Michael -- Michael Haggerty mhagger@xxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html