On Wed, Dec 23, 2015 at 11:53 PM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote:
> On Wed, Dec 23, 2015 at 4:03 PM, Christian Couder
> <christian.couder@xxxxxxxxx> wrote:
>> Factor out code into new_untracked_cache(), which will be used
>> multiple times in a later commit.
>
> Odd indentation: s/^\s+//
Yeah, will fix.
>> Signed-off-by: Christian Couder <chriscool@xxxxxxxxxxxxx>
>> ---
>> diff --git a/dir.c b/dir.c
>> @@ -1938,16 +1938,20 @@ void add_untracked_ident(struct untracked_cache *uc)
>> strbuf_addch(&uc->ident, 0);
>> }
>>
>> +static void new_untracked_cache(void)
>> +{
>> + struct untracked_cache *uc = xcalloc(1, sizeof(*uc));
>> + strbuf_init(&uc->ident, 100);
>> + uc->exclude_per_dir = ".gitignore";
>> + /* should be the same flags used by git-status */
>> + uc->dir_flags = DIR_SHOW_OTHER_DIRECTORIES | DIR_HIDE_EMPTY_DIRECTORIES;
>> + the_index.untracked = uc;
>> +}
>
> This and the previous patch both move the same code around. As a
> reviewer, I could easily see the two patches combined, and would not
> find the unified patch onerous to review.
Ok, I will squash them.
By the way it looks like I have overlooked some reviews by David and
Tosten from the previous round.
Sorry about that. I will take them into account in the next version.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html