Junio C Hamano <gitster@xxxxxxxxx> writes:
> Use of "cat-file -p" is a bad manner in scripts, as we reserve the
> right to change what "-p" output looks like purely on human
> usability. "cat-file tag", perhaps?
>
> Also,
>
> $ git grep ' PGP '
>
> in our source tells me that we use a bit tighter pattern even when
> we are casually trying to see if the thing looks like a PGP signed
> payload.
>
> if test "$allowunsigned" = "true" ||
> git cat-file "$newrev" |
> grep -q '^-----BEGIN PGP SIGNATURE-----$'
> then
> ...
>
> or something?
I think an intelligent reader would have understood what I meant,
but the 'cat-file' in the above needs to say what type of thing
it is asking to dump, i.e.
if test "$allowunsigned" = "true" ||
git cat-file tag "$newrev" |
grep -q '^-----BEGIN PGP SIGNATURE-----$'
then
Sorry for the noise.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html