Re: [PATCH] update-hook: remove all functionality that should be in hooks/post-receive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Theodore Tso <tytso@xxxxxxx> writes:

> On Sat, Mar 24, 2007 at 08:14:31AM +0000, Andy Parkins wrote:
>> So: ideally, what /I/ would like is that git distributes the script in a 
>> standard location like /usr/share/doc/git/contrib/post-receive-emailer 
>> with the execute bit already set; that can be easily linked to or 
>> called from the actual post-receive hook.
>
> I wonder if this is a good idea to do for all or most of the template
> scripts, so that they can get automatically updated when git is
> updated, instead of having the problem we had before where the hook
> script got updated to match changes in git, but ancient repositories
> would still have the old script.

I do agree that dealing with ancient scripts that casually used
implementation details that later versions broke is a problem.

But the recent updates to the mail-hook are backward compatible
only in the sense that as long as the user configures it, the
new script can mimic old version's behaviour (in other words, it
was not backward compatible at all).  I think forcing updates to
the hooks automatically is worse.  I'd rather keep hooks private
to repository owner's concern.

While I think it would be great to have a central clearinghouse
for people to share and enjoy useful hook collections for
various workflows and use cases, I do not necessarily think
inside git.git project itself is the best place to do so.


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]