Re: [PATCHv3] Makefile: add missing phony target

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Elia Pinto <gitter.spiros@xxxxxxxxx> writes:

> Add some missing phony target to Makefile.
>
> Signed-off-by: Elia Pinto <gitter.spiros@xxxxxxxxx>
> Helped-by: Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx>
> ---
> This is the third version of this patch.

Thanks. I double-checked with

grep .PHONY Makefile | sed 's/.PHONY: //; s/#.*//' | tr ' ' '\n' | sort | uniq -c | sort -n

there are no duplicate .PHONY, and all .PHONY targets are indeed .PHONY
ones, so the patch is now

Reviewed-by: Matthieu Moy <Matthieu.Moy@xxxxxxx>

> Compared to the previous I have added only the missing phony 
> target as suggested by Matthieu Moy

Note: my comments were not meant to be an objection to the additional
refactoring. At least some of the hunks definitely made sense to me, but
they are better done in a separate patch.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]