On Mon, Dec 14, 2015 at 2:58 PM, Eric Sunshine <ericsunshine@xxxxxxxxx> wrote: >> + /* We deliberately ignore the return value */ > > This comment tells us what the code itself already says, but not why > the value is being ignored. The reader still has to consult the commit > message to learn that detail, which makes the value of the comment > questionable. It at least tells you it's not because of sloppiness. ;) I'll elaborate that comment a bit further in a resend though. Thanks, Stefan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html