On Mon, Dec 14, 2015 at 03:46:25PM -0500, Jeff King wrote:
> I don't think that fix is right, though. We should be passing "host" to
> gethostbyname.
Here it is in patch form. It can go on top of ep/ident-with-getaddrinfo.
-- >8 --
Subject: [PATCH] ident: fix undefined variable when NO_IPV6 is set
Commit 00bce77 (ident.c: add support for IPv6, 2015-11-27)
moved the "gethostbyname" call out of "add_domainname" and
into the helper function "canonical_name". But when moving
the code, it forgot that the "buf" variable is passed as
"host" in the helper.
Reported-by: johan defries <johandefries@xxxxxxxxx>
Signed-off-by: Jeff King <peff@xxxxxxxx>
---
ident.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ident.c b/ident.c
index 4e7f99d..00a62e0 100644
--- a/ident.c
+++ b/ident.c
@@ -86,7 +86,7 @@ static int canonical_name(const char *host, struct strbuf *out)
freeaddrinfo(ai);
}
#else
- struct hostent *he = gethostbyname(buf);
+ struct hostent *he = gethostbyname(host);
if (he && strchr(he->h_name, '.')) {
strbuf_addstr(out, he->h_name);
status = 0;
--
2.7.0.rc0.348.g8e7037f
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html