On Fri, 2015-12-11 at 16:23 -0800, Junio C Hamano wrote: > David Turner <dturner@xxxxxxxxxxxxxxxx> writes: > > > The previous review was here: > > http://permalink.gmane.org/gmane.comp.version-control.git/279062 > > > > Michael wrote: > >> Hmmm, I thought our convention was to define typedefs for functions > >> themselves, not for the pointer-to-function; e.g., > >> > >> typedef struct ref_transaction *ref_transaction_begin_fn(struct > >> strbuf *err); > >> > >> (which would require `struct ref_be` to be changed to > >> > >> ref_transaction_begin_fn *transaction_begin; > > > > And you agreed. So I changed it. Do you want me to change it back? > > Sorry about that. I was agreeing to my mistaken understanding of > what was pointed out X-<. > > We do prefer fn(args) over (*fn)(args) and somehow I mixed that up > with the declaration style. So I should change it back? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html