Stefan Beller <sbeller@xxxxxxxxxx> writes: >> + git push --recurse-submodules=on-demand --no-recurse-submodules ../pub.git master && >> + # Check that the submodule commit did not get there > > Do we want to check here that the supermodule commit did get there, > instead of only checking the submodule? Hmm, your point is that when the push succeeds, (1) the command should return with 0 status, (2) the branch in the superproject should update to the right commit, and (3) none of the submodule should be affected, and the current test does not check the second one? I think that makes sense, in somewhat a paranoid way ;-). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html