Re: [PATCH v2 2/2] clean: new option --exclude-from

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



James <rouzier@xxxxxxxxx> writes:

> +static int exclude_from_cb(const struct option *opt,
> +				     const char *arg, int unset)
> +{
> +	struct dir_struct *dir = opt->value;
> +	add_excludes_from_file(dir, arg);

I suspect this is wrong.  add_excludes_from_file() creates a
new excludes_list that is separate from the command line level and
pushes that down to the exclude stack.  You'd instead need to add
each line of the input at the same EXC_CMDL level like -e <pattern>
option does from the command line, I would think.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]