Duy Nguyen <pclouds@xxxxxxxxx> writes: > On Thu, Dec 3, 2015 at 7:17 PM, Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> wrote: >> The solution in d95138e is reverted in this commit. Instead we reuse the >> solution from c056261 [4]. c056261 fixes another setup-messed-up-by-alias >> by saving and restoring env for git-clone and git-init. Now I conclude >> that setup-messed-by-alias is always evil. So the env restoration is >> done for _all_ commands whenever aliases are involved. It fixes what >> d95138e tries to fix. And it does not upset git-clone-inside-hooks. > > (Reviewer hat on) I wrote env restoration is done for all commands, > but the patch is actually about all _builtin_ commands. External ones > do not receive this treatment. FIx is in the next reroll. Thanks for being careful. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html