Hi Christian,
On Wed, 25 Nov 2015, Christian Couder wrote:
> diff --git a/config.c b/config.c
> index 248a21a..d720b1f 100644
> --- a/config.c
> +++ b/config.c
> @@ -691,6 +691,13 @@ static int git_default_core_config(const char *var, const char *value)
> trust_ctime = git_config_bool(var, value);
> return 0;
> }
> + if (!strcmp(var, "core.trustmtime")) {
> + if (!strcasecmp(value, "default") || !strcasecmp(value, "check"))
> + trust_mtime = -1;
> + else
> + trust_mtime = git_config_maybe_bool(var, value);
If `core.trustmtime` is set to `OMG, never!`, `git_config_maybe_bool()`
will set trust_mtime to -1, i.e. the exact same value as if you had set
the variable to `default` or `check`...
Maybe you want to be a bit stricter here and either test the return value
of `git_config_maybe_bool()` for -1 (and warn in that case), or just
delete the `maybe_`?
Ciao,
Dscho
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html