Re: [PATCH] test-lib-functions: fix logic error in test_must_fail

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 25, 2015 at 12:05:36AM +0000, Ramsay Jones wrote:

> >   ...
> >   if ! list_contains "$_test_ok" success && test "$exit_code" -eq 0
> >   then
> > 	return 0
> >   fi
>     ^^
> Is this intended to be part of the if..elif.. chain, or a separate
> initial conditional? Hmm, actually it doesn't matter since it has
> exactly the same logic error as the original patch ... :-D

I meant it as part of the same one, but yeah, it has the wrong "return"
(I noticed it when writing up the real patch as a SQUASH on top of
Lars's topics).

> > They don't fail consistently. It's a SIGPIPE race.
> 
> Yes, and unfortunately I can't get it to happen for me.
> Which platforms has it been observed on?

I haven't tried to reproduce it, but I think it was seen originally in
the Travis build.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]