On Tue, Nov 24, 2015 at 10:17:08PM +0000, John Keeping wrote:
> I wonder if we should do this to help debug SSL issues:
>
> -- >8 --
> diff --git a/git-send-email.perl b/git-send-email.perl
> index e057051..6d4e0ee 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -1317,6 +1317,10 @@ Message-Id: $message_id
> require Net::SMTP::SSL;
> $smtp_domain ||= maildomain();
> require IO::Socket::SSL;
> + if ($debug_net_smtp) {
> + no warnings 'once';
> + $IO::Socket::SSL::DEBUG = 1;
> + }
> # Net::SMTP::SSL->new() does not forward any SSL options
> IO::Socket::SSL::set_client_defaults(
> ssl_verify_params());
> -- 8< --
That certainly looks like a reasonable thing to be doing, assuming that
the output from IO::Socket::SSL is generally helpful.
> > > Maybe we shouldn't worry too much about that, but should instead put the
> > > invalid path into the error message:
> > >
> > > die "CA path \"$smtp_ssl_cert_path\" does not exist.";
> >
> > Given what I wrote above, yeah, I'd agree that is sufficient (and I do
> > think mentioning the path is helpful).
>
> I'll change it to this in a re-roll.
Thanks.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html