On Fri, Nov 20, 2015 at 12:56:04PM +0000, Luke Diamand wrote: > >>> git-p4: retry kill/cleanup operations in tests with timeout > >>> git-p4: add p4d timeout in tests > >>> git-p4: add trap to kill p4d on test exit > >> > >> These are all fairly gross, and I don't have p4d to test with myself. > >> But if we assume they're all necessary, I suppose it's the best we can > >> do. > > > > Unfortunately I think they are necessary. However, if someone finds a better way for stable p4d tests then I would be happy to see them go away, again. > > I think that's just how p4d is I'm afraid. It doesn't like being > stopped and started quickly (I guess it's not a normal use-case for > most p4 users). I've made various unsuccessful attempts in the past to > make these tests work reliably, and Lars' changes are far better than > anything I ever managed. Thanks for the extra context. I hope I didn't sound too negative in my initial assessment. It was meant to be "this is lamentable but probably necessary". -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html