On 2015-11-20 22.08, Stefan Beller wrote:
The patch looks good at first glance, one minor remark below:
>
> diff --git a/run-command.c b/run-command.c
> @@ -1071,70 +1089,31 @@ static void pp_output(struct parallel_processes *pp)
>
> static int pp_collect_finished(struct parallel_processes *pp)
> {
> - int i = 0;
> - pid_t pid;
> - int wait_status, code;
> + int i, code;
code is probably "return code"?
woud "ret_value", "res" or "rc" make that more clear ?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html