Re: [PATCH] Escape Git's exec path in contrib/rerere-train.sh script

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 08, 2015 at 12:27:55PM +0100, Daniel Knittl-Frank wrote:

> Whitespace can cause the source command to fail. This is usually not a
> problem on Unix systems, but on Windows Git is likely to be installed
> under "C:/Program Files/", thus rendering the script broken.
> 
> Signed-off-by: Daniel Knittl-Frank <knittl89+git@xxxxxxxxxxxxxx>
> ---
>  contrib/rerere-train.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/contrib/rerere-train.sh b/contrib/rerere-train.sh
> index 36b6fee..52ad9e4 100755
> --- a/contrib/rerere-train.sh
> +++ b/contrib/rerere-train.sh
> @@ -7,7 +7,7 @@ USAGE="$me rev-list-args"
>  
>  SUBDIRECTORY_OK=Yes
>  OPTIONS_SPEC=
> -. $(git --exec-path)/git-sh-setup
> +. "$(git --exec-path)/git-sh-setup"

Thanks, this makes sense.

The "normal" scripts just use ". git-sh-setup", but they have the
benefit of being run under the "git" wrapper, so the exec-path is
already in their PATH. This one is meant to be used directly, so it
needs this.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]