Re: [PATCH v4 09/12] Add several uses of get_object_hash.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 10, 2015 at 02:22:27AM +0000, brian m. carlson wrote:

> diff --git a/patch-ids.c b/patch-ids.c
> index bf81b923..83229a0d 100644
> --- a/patch-ids.c
> +++ b/patch-ids.c
> @@ -8,10 +8,10 @@ static int commit_patch_id(struct commit *commit, struct diff_options *options,
>  		    unsigned char *sha1)
>  {
>  	if (commit->parents)
> -		diff_tree_sha1(commit->parents->item->object.sha1,
> -		               commit->object.sha1, "", options);
> +		diff_tree_sha1(get_object_hash(commit->parents->item->object),
> +		               get_object_hash(commit->object), "", options);

I haven't looked carefully at this series yet, but while applying I
noticed that git complained about whitespace here (long run of spaces
which could be using tabs).

I've fixed it up for what I'm queuing, but you may want to do so
locally, too.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]