On Thu, Nov 19, 2015 at 11:20 AM, René Scharfe <l.s.r@xxxxxx> wrote: > Signed-off-by: Rene Scharfe <l.s.r@xxxxxx> > --- > diff --git a/t/t1450-fsck.sh b/t/t1450-fsck.sh > @@ -176,6 +176,18 @@ test_expect_success 'integer overflow in timestamps is reported' ' > +test_expect_success 'commit with NUL in header' ' > + git cat-file commit HEAD >basis && > + sed "s/author ./author Q/" <basis | q_to_nul >commit-NUL-header && > + new=$(git hash-object -t commit -w --stdin <commit-NUL-header) && > + test_when_finished "remove_object $new" && > + git update-ref refs/heads/bogus "$new" && > + test_when_finished "git update-ref -d refs/heads/bogus" && > + test_must_fail git fsck 2>out && > + cat out && What is the purpose of this 'cat'? > + grep "error in commit $new.*unterminated header: NUL at offset" out > +' > @@ -276,6 +288,26 @@ test_expect_success 'tag with bad tagger' ' > +test_expect_failure 'tag with NUL in header' ' > + sha=$(git rev-parse HEAD) && > + q_to_nul >tag-NUL-header <<-EOF && > + object $sha > + type commit > + tag contains-Q-in-header > + tagger T A Gger <tagger@xxxxxxxxxxx> 1234567890 -0000 > + > + This is an invalid tag. > + EOF > + > + tag=$(git hash-object --literally -t tag -w --stdin <tag-NUL-header) && > + test_when_finished "remove_object $tag" && > + echo $tag >.git/refs/tags/wrong && > + test_when_finished "git update-ref -d refs/tags/wrong" && > + test_must_fail git fsck --tags 2>out && > + cat out && Ditto. > + grep "error in tag $tag.*unterminated header: NUL at offset" out > +' > + > -- > 2.6.3 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html