In pack-check.c, line 129, a caller-supplied verification function is called. The function returns an int, but that return value is ignored. The only caller of verify_pack is in builtin/fsck.c, whose verify_fn *does* return a meaningful error code (which is then ignored). If it were not ignored, fsck might return a different error code (in the unlikely event that a weird object gets into a pack and is somehow not totally corrupt enough to fail an earlier check). I think we should probably have verify_pack return a non-zero result if any call to verify_fn returns a non-zero result. Any objections to this? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html