On Tue, Nov 17, 2015 at 4:34 AM, Luke Diamand <luke@xxxxxxxxxxx> wrote: >>> While implementing it I thought more about it. P4D is only >>> supported on platforms that support the date function. That means >>> these tests will only run on platforms that support the date >>> function. Consequently I wondered if this would justify the >>> slightly more complicated code. However, if you think this change >>> would help the patch to get accepted then I will add it. >> >> I don't feel strongly about it, and it's not my call anyhow. Opinions >> of Junio, Peff (as interim maintainer), and Luke weigh much more >> heavily than my own. Punting on dynamic detection of "date +%s" may be >> perfectly acceptable with the attitude that it can be implemented >> later if someone runs across a case where it's actually needed. > > Which other platforms are we talking about here? > > https://www.perforce.com/downloads/helix > > From there, you can get Solaris10, HP-UX, AIX and various flavours of BSD. > Solaris supports "date +%s". The question about "date +%s" portability arose with a suggestion to employ it in git-filter-branch[1]. Apparently, the concern about Solaris was raised in response to a Stack Overflow question[2] which claimed that +%s was not supported by that OS. Unfortunately, however, [2] did not indicate to which (older?) versions of Solaris that shortcoming applied. If Solaris 10 does support +%s, and the Perforce product is only available for Solaris 10, then perhaps concern about +%s a non-issue(?). [1]: http://git.661346.n2.nabble.com/FEATURE-REQUEST-Filter-branch-extend-progress-with-a-simple-estimated-time-remaning-td7638200.html#a7638504 [2]: http://stackoverflow.com/questions/2445198/get-seconds-since-epoch-in-any-posix-compliant-shell -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html