On Mon, Nov 16, 2015 at 11:20 PM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote:
> Since git-send-email.perl already configures GetOpt::Long with the
> 'pass_through' option, one possibility would be to invoke
> GetOptions() once for --list-aliases (or --dump-aliases), and then
> again for the normal options. Doing so may be a bit ugly; on the
> other hand, it does indicate pretty clearly that --list-aliases is a
> distinct "mode" of operation. On top of your patch, it might look
> something like this:
>
> --- 8< ---
> diff --git a/git-send-email.perl b/git-send-email.perl
> index ee14894..cada5ea 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -296,6 +296,12 @@ $SIG{INT} = \&signal_handler;
>
> my $help;
> my $rc = GetOptions("h" => \$help,
> + "list-aliases" => \$list_aliases);
> +usage() unless $rc;
> +die "--list-aliases incompatible with other options\n"
> + if !$help and $list_aliases and @ARGV;
> +
> +$rc = GetOptions(
> "sender|from=s" => \$sender,
> "in-reply-to=s" => \$initial_reply_to,
> "subject=s" => \$initial_subject,
> @@ -349,7 +355,6 @@ my $rc = GetOptions("h" => \$help,
> "force" => \$force,
> "xmailer!" => \$use_xmailer,
> "no-xmailer" => sub {$use_xmailer = 0},
> - "list-aliases" => \$list_aliases,
> );
>
> usage() if $help;
> --- 8< ---
>
> Though, it may be overkill for this minor use-case.
I actually really like this approach. I will squash it in.
Regards,
Jake
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html