Re: [PATCH] push: add recurseSubmodules config option

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 16.11.2015 um 19:31 schrieb Mike Crowe:
On Monday 16 November 2015 at 10:15:24 -0800, Stefan Beller wrote:
The code itself looks good to me, one nit in the tests though.

@@ -79,6 +87,119 @@ test_expect_success 'push succeeds after commit was pushed to remote' '
         )
  '

+test_expect_success 'push succeeds if submodule commit not on remote but using on-demand on command line' '
+       (
+               cd work/gar/bage &&
+               >recurse-on-demand-on-command-line &&
+               git add recurse-on-demand-on-command-line &&
+               git commit -m "Recurse on-demand on command line junk"
+       ) &&
+       (
+               cd work &&
+               git add gar/bage &&
+               git commit -m "Recurse on-demand on command line for gar/bage" &&
+               git push --recurse-submodules=on-demand ../pub.git master &&
+               # Check that the supermodule commit got there
+               git fetch ../pub.git &&
+               git diff --quiet FETCH_HEAD master

Missing && chain here.

Oh, well spotted! I'll provide an updated version.

Looking good for me too!

Cool, another issue from my Wiki that's being worked on!
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]