On Sun, Nov 15, 2015 at 2:14 PM, Johan Herland <johan@xxxxxxxxxxx> wrote: >> --- >> I do not remember what version this was since it has been an age ago >> that I sent the previous code. This is mostly just a rebase onto current >> next. I believe I have covered everything previous reviewers noted. > > Looks good to me. > >> I'm interested in whether this is the right direction, as my longterm >> goal is to be able to push/pull notes to a specific namespace (probably >> refs/remote-notes/*, since actually modifying to use >> refs/remotes/notes/* is difficult to send to users, and remote-notes >> makes the most useful sense). The first part of this is allowing merge >> to come from an arbitrary reference, as currently it is not really >> possible to merge from refs/remote-notes as we'd need it to be. > > Yes, I agree that merging from refs outside refs/notes/ should become possible. > Thanks. > A related topic that has been discussed (although I cannot remember if > any conclusion was reached) is whether to allow more notes operations > - specifically _read-only_ operations - on notes trees outside > refs/notes/. I believe this should also become possible, although I > haven't thoroughly examined all implications. > > ...Johan > > This was discussed at some point on one of the versions of my patch. The tricky part is in how to get it implemented correctly. We need to be able to correctly handle DWIM logic for things, and ensure that what we're operating on actually looks "note-like" since we don't really want to perform read-only ops on refs that don't hold notes like objects. Regards, Jake -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html