Re: [PATCH] run-command: detect finished children by closed pipe rather than waitpid

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



including the list and all others this time.

>>                         if (code < 0) {
>>                                 pp->shutdown = 1;
>> -                               kill_children(pp, SIGTERM);
>> +                               kill_children(pp, -code);
>
>
> I'll see what this means for our kill emulation on Windows. Currently, we
> handle only SIGTERM.

So currently we only pass in SIGTERM from the callers, and I certainly
only intend
to use that signal. I just thought special casing the SIGTERM signal
would do no good
in terms of design here.

So maybe that was not the right thought and we do have to special case
SIGTERM here?

I worked with another large proprietary parallel program (spawning
child processes) before.
If you pressed CTRL-C, it would omit a message like:

    Sending no further input to the children

If you press Ctrl-C again, it would print:

    Sending SIGTERM to children, to shut them down gracefully

If you pressed once again, you'll get a

    User seems to be angry, shutting down hard, sending SIGKILL
    $ # that was fast now.

I guess we don't want to play around like that, but if the parent process gets
a SIGTERM, we relay that and other signals we ignore for now?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]