On 11/09/2015 08:46 PM, Ramsay Jones wrote: > On 09/11/15 17:03, Michael Haggerty wrote: >> [...] >> diff --git a/refs.c b/refs.c >> index f48c58a..9aff0c8 100644 >> --- a/refs.c >> +++ b/refs.c >> @@ -1,6 +1,6 @@ >> #include "cache.h" >> +#include "refs/refs-internal.h" >> #include "lockfile.h" >> -#include "refs.h" > > This looked wrong to me, until I had read the remainder of the > patch and noticed that the 'internal' header #included the > 'public' interface header. > > Unfortunately, this still feels wrong to me! I would rather that > the internal header _not_ include the public header (so, include > them _both_ when necessary). Just my opinion, which you can simply > ignore. :-D Yeah, I was of two minds about this. I will change this in the next round. Thanks for your review! Michael -- Michael Haggerty mhagger@xxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html