On Tue, Nov 03, 2015 at 01:51:54PM -0800, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > I agree with Junio that "-R" is a more sensible default, but I don't > > think that should be necessary. We already set LESS when running the > > pager (and if you are overriding it, you are already in trouble, because > > git itself will generate ANSI codes by default). > > I do not quite understand this part. Inside git itself when we > spawn the pager we export LESS with a sensible default, exactly to > help users who do not have LESS set and exported. This one however > is not spawned by git but the end-user piping output of diff-hilite. Oh, you're right. I mistook it as instructions for what to put in pager.log, but that is clearly not what this is. I agree that telling the user to use "-R" here is a good idea. And indeed, the instructions just below the hunk in question describe setting it properly in your config (with less, and no "-R"). So I was simply confused and not reading carefully enough. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html