On Sun, 2015-11-01 at 09:17 +0100, Michael Haggerty wrote: > On 10/28/2015 03:14 AM, David Turner wrote: > > The common ref code will build up a ref transaction. Backends will > > then commit it. So the transaction creation and update functions should > > be in the common code. We also need to move the ref structs into > > the common code so that alternate backends can access them. > > > > Later, we will modify struct ref_update to support alternate backends. > > I would prefer that this and later patches *not* add declarations to the > public API in refs.h for functions and data that are only meant to be > used by other reference backends. > > So I'm working on a modified version of your series that declares such > functions in refs-internal.h [1] instead. I hope to submit it tomorrow. OK, I will fix up your other two issues and then wait for that series. > Actually, I have half a mind to move all of the refs-related files to a > subdirectory, like > > refs.h > refs/refs.c > refs/refs-internal.h > refs/refs-be-files.c > refs/refs-be-lmdb.c <- still to come > > What would you think of that? Since we're moving stuff around anyway, we might as well introduce a little more hierarchy. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html