On Sun, Nov 1, 2015 at 3:06 PM, Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: >> +--[no-]progress:: >> + Progress status is reported on the standard error stream >> + by default when it is attached to a terminal, unless --quiet >> + is specified. This flag enables progress reporting even if not >> + attached to a terminal, regardless of -q. > > The mix of -q and --quiet is inconsistent and potentially confusing. I > suspect that your intention was to hint that they are equivalent, > however, the reader who is not familiar with -q as an alias of --quiet > may now be forced to look up both options, rather than just one, only > to discover that they are the same, thus potentially requiring extra > effort. It probably would be better to consistently use --quiet. > > Also, quoting with backticks is recommended: `--quite` > > The rest of the patch looks good. Good! Going for v7. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html