On 2015-10-28 14:58, Eric Sunshine wrote:
> > + }
> > + if (!curl_http_proxy) {
> > + copy_from_env(&curl_http_proxy, "ALL_PROXY");
> > + copy_from_env(&curl_http_proxy, "all_proxy");
> > + }
>
> If this sort of upper- and lowercase environment variable name
> checking is indeed desirable, I wonder if it would make sense to fold
> that functionality into the helper function.
It's just for consistency with libcurl here, not generally desirable; so I don't
think it makes sense to add it to the helper.
Otherwise, will fix. Thanks.
Cheers,
Knut
--
Vorstandsvorsitzender/Chairman of the board of management:
Gerd-Lothar Leonhart
Vorstand/Board of Management:
Dr. Bernd Finkbeiner, Dr. Arno Steitz
Vorsitzender des Aufsichtsrats/
Chairman of the Supervisory Board:
Philippe Miltin
Sitz/Registered Office: Tuebingen
Registergericht/Registration Court: Stuttgart
Registernummer/Commercial Register No.: HRB 382196
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html