On Thu, Oct 29, 2015 at 6:14 PM, Eric Sunshine <ericsunshine@xxxxxxxxx> wrote: >> + else if (!me->overwrite && submodule->update != NULL) > > Although "foo != NULL" is unusual in this code-base, it is used > elsewhere in this file, including just outside the context seen above. > Okay. ok, I'll clean that up as we go. >> + free((void *)submodule->update); > > Minor: Every other 'free((void *) foo)' in this file has a space after > "(void *)", one of which can be seen in the context just above. done -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html