Luke Diamand <luke@xxxxxxxxxxx> writes: > On 9 September 2015 at 22:52, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> Luke Diamand <luke@xxxxxxxxxxx> writes: >> ... >> def currentGitBranch(): >> return read_pipe("git name-rev HEAD").split(" ")[1].strip() >> >> Yuck. I know it is not entirely the fault of this patch, but >> shouldn't it be reading from >> >> $ git symbolic-ref HEAD >> >> and catch the error "fatal: ref HEAD is not a symbolic ref" and use >> it as a signal to tell that the HEAD is detached? > > That sounds much nicer. I'll redo the patch accordingly. No need to rush, but should I expect a reroll of this sometime, or have things around this topic changed to make this topic no longer necessary? I am only asking so that I can decide to either keep or drop ld/p4-detached-head topic that is listed in the [Stalled] section for quite some time [*1*]. Thanks. [Footnote] *1* Not that my dropping a topic from 'pu' means very much; a dropped topic can still be submitted and requeued after all. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html