On Tue, 27 Oct 2015 at 19:18:26, Junio C Hamano wrote:
> [...]
> When I asked 'Is transfer.hiderefs insufficient?', I wasn't
> expecting it to be usable out of box. It was a suggestion to build
> on top of it, instead of adding a parallel support for something
> specific to namespaces.
>
Agreed, and I do have a couple of patches to improve hideRefs. I still
have some questions before submitting them, though. See below.
> For example, if the problem is that you cannot tell ref_is_hidden()
> what namespace the ref is from because it is called after running
> strip_namespace(), perhaps you can find a way to have the original
> "namespaced ref" specified on transfer.hiderefs and match them?
> Then in repository for project A, namespaced refs for project B can
> be excluded by specifying refs/namespaces/B/* on transfer.hiderefs.
>
> Perhaps along the lines of this?
> [...]
My original question remains: Do we want to continue supporting things
like transfer.hideRefs=.have (which currently magically hides all refs
outside the current namespace)? For 100% backwards compatibility, we
would have to. On the other hand, one could consider the current
behavior a bug and one could argue that it is weird enough that probably
nobody (apart from me) relies on it right now. If we decide to keep it
anyway, I think it should be documented.
Another patch I have in my patch queue adds support for a whitelist mode
to hideRefs. There are several ways to implement that:
1. Make transfer.hideRefs='' hide all refs (it currently does not). The
user can then whitelist refs explicitly using negative patterns
below that rule. This is how my current implementation works. Using
the empty string seemed most natural since hideRefs matches prefixes
and every string has the empty string as a prefix. If that seems too
weird, we could probably special case something like
transfer.hideRefs='*' instead.
2. Detect whether hideRefs only contains negative patterns. Switch to
whitelist mode ("hide by default") in that case.
3. Add another option to switch between "hide by default" and "show by
default".
I personally prefer the first option. Any other opinions?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html