Re: git-credential-cache--daemon quits on SIGHUP, can we change it to ignore instead?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Noam Postavsky <npostavs@xxxxxxxxxxxxxxxxxxxxx> writes:

> On Tue, Oct 20, 2015 at 10:35 PM, Noam Postavsky
> <npostavs@xxxxxxxxxxxxxxxxxxxxx> wrote:
>> On Sun, Oct 18, 2015 at 1:58 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>>> I cannot speak for the person who was primarily responsible for
>>> designing this behaviour, but I happen to agree with the current
>>> behaviour in the situation where it was designed to be used.  Upon
>>> the first use in your session, the "daemon" is auto-spawned, you can
>>> keep talking with that same instance during your session, and you do
>>> not have to do anything special to shut it down when you log out.
>>> Isn't that what happens here?
>>
>> After looking at this some more, I've discovered this is NOT what
>> actually happens here. If I "git push" from a shell and then log out
>> and log in again, another "git push" does NOT ask me for a password.
>> In other words, the daemon is NOT shut down automatically when I log
>> out. Given that, does it make sense to change the daemon to ignore
>> SIGHUP, or is there some way to change it so that it does exit on
>> logout?

I have a feeling that it would be moving in a wrong direction to
change the code to ignore HUP, as I do think "logout to shutdown"
would be the desired behaviour.  If you are not seeing that happen,
perhaps the first thing to do is to figure out why and fix the code
so that it happens?

I dunno.  I'll cc Peff so that he can take a look when he comes
back.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]