On Fri, Oct 23, 2015 at 08:02:51AM +0200, Johannes Sixt wrote: > The earlier rewrite f28e3ab2 (read_branches_file: simplify string handling) > of read_branches_file() lost an fclose() call. Put it back. > > As on Windows files that are open cannot be removed, the leak manifests in > a failure of 'git remote rename origin origin' when the remote's URL is > specified in .git/branches/origin, because by the time that the command > attempts to remove this file, it is still open. Thanks for catching. This was due to my last-minute rewrite of strbuf_read_file into fopen/strbuf_getline. Your patch looks good to me. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html