On Mon, Oct 19, 2015 at 12:28 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > @@ -733,7 +733,7 @@ static int handle_commit_msg(struct mailinfo *mi, struct strbuf *line) > } > > if (mi->use_inbody_headers && mi->header_stage) { > - mi->header_stage = check_header(mi, line, s_hdr_data, 0); > + mi->header_stage = check_header(mi, line, mi->s_hdr_data, 0); Would it make sense to get rid of the third argument for check_header instead? We already pass in mi, so check_header can access s_hdr_data? > if (mi->header_stage) -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html