Re: [PATCH v3 14/34] mailinfo: move filter/header stage to struct mailinfo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 19, 2015 at 12:28 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:

> @@ -28,6 +31,7 @@ static enum  {
>
>  static struct strbuf charset = STRBUF_INIT;
>  static int patch_lines;
> +

nitpicking here. Why is this patch the best in series to introduce a
new line at this position? ;)

>  static struct strbuf **p_hdr_data, **s_hdr_data;
>  static int use_scissors;
>  static int add_message_id;
> @@ -718,25 +722,25 @@ static int is_scissors_line(const struct strbuf *line)
>                 gap * 2 < perforation);
>  }
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]